Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new beta non-rfc fields in dns managed zone #5493

Conversation

modular-magician
Copy link
Collaborator

Fixes: #5062

I cribbed the object_to_bool and bool_to_object code from: GoogleCloudPlatform/magic-modules#3007 as this will likely make it in before that.

Release Note Template for Downstream PRs (will be copied)

dns: `google_dns_managed_zone` added support for Non-RFC1918 fields for reverse lookup and fowarding paths.

Derived from GoogleCloudPlatform/magic-modules#3026

…p#3026)

* Add support for new beta non-rfc fields in dns managed zone

* Test updating forwarding path

* Forgot to remove a param

* Typo

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Jan 25, 2020
@modular-magician modular-magician merged commit befe7e1 into hashicorp:master Jan 25, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Non-RFC1918 support
1 participant